linux-kernel - Re: [PATCH] PCI: Add missing link delays required by the PCIe spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f741e3a-0878-b914-39d8-a64a02484cb5@gmx.de>
Date:   Thu, 22 Aug 2019 20:29:09 +0200
From:   Matthias Andree <matthias.andree@....de>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Len Brown <lenb@...nel.org>, Lukas Wunner <lukas@...ner.de>,
        Keith Busch <keith.busch@...el.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Alexandru Gagniuc <mr.nuke.me@...il.com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Paul Menzel <pmenzel@...gen.mpg.de>,
        Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>,
        Justin Forbes <jmforbes@...uxtx.org>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: Add missing link delays required by the PCIe spec

Am 21.08.19 um 14:45 schrieb Mika Westerberg:
> Hi all,
>
> As the changelog says this is reworked version that tries to avoid reported
> issues while at the same time fix the missing delays so we can get ICL
> systems and at least the one system with Titan Ridge controller working
> properly.
>
> @Matthias, @Paul and @Nicholas: it would be great if you could try the
> patch on top of v5.4-rc5+ and verify that it does not cause any issues on
> your systems.
>
>  drivers/pci/pci-driver.c |  19 ++++++
>  drivers/pci/pci.c        | 127 ++++++++++++++++++++++++++++++++++++---
>  drivers/pci/pci.h        |   1 +
>  3 files changed, 137 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
> index a8124e47bf6e..9aec78ed8907 100644

...

Mika, Bjorn, Rafael,

quick smoke test, this test applied with git-am on top
v5.3-rc5-149-gbb7ba8069de9, reboot, suspend, wake, suspend, wake,
hibernate, wake, looks good to me. The top of git log --pretty-short is
shown below.

Couldn't test on v5.4-rc5 though as I've handed off my time machine for
repairs,
I seem to recall they said something about the flux compensator.

Thanks.

Regards,
Matthias

> commit 0fa4a33a010bdd24edb50b9179109c6639d5f6b5 (HEAD -> master)
> Author: Mika Westerberg <mika.westerberg@...ux.intel.com>
>
>     PCI: Add missing link delays required by the PCIe spec
>
> commit bb7ba8069de933d69cb45dd0a5806b61033796a3 (origin/master,
> origin/HEAD)
> Merge: 2babd34df229 e4427372398c
> Author: Linus Torvalds <torvalds@...ux-foundation.org>
>
>     Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm
>