linux-kernel - Re: [PATCHv2] lib/test_kasan: add roundtrip tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Aug 2019 16:48:57 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Mark Rutland <mark.rutland@....com>
Cc:     linux-kernel@...r.kernel.org,
        Alexander Potapenko <glider@...gle.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Will Deacon <will.deacon@....com>
Subject: Re: [PATCHv2] lib/test_kasan: add roundtrip tests

On Mon, 19 Aug 2019 17:14:49 +0100 Mark Rutland <mark.rutland@....com> wrote:

> In several places we need to be able to operate on pointers which have
> gone via a roundtrip:
> 
> 	virt -> {phys,page} -> virt
> 
> With KASAN_SW_TAGS, we can't preserve the tag for SLUB objects, and the
> {phys,page} -> virt conversion will use KASAN_TAG_KERNEL.
> 
> This patch adds tests to ensure that this works as expected, without
> false positives which have recently been spotted [1,2] in testing.
> 
> [1] https://lore.kernel.org/linux-arm-kernel/20190819114420.2535-1-walter-zh.wu@mediatek.com/
> [2] https://lore.kernel.org/linux-arm-kernel/20190819132347.GB9927@lakrids.cambridge.arm.com/
> 
>
> ...
>

The only change I'm seeing from v1 is:

--- a/lib/test_kasan.c~lib-test_kasan-add-roundtrip-tests-v2
+++ a/lib/test_kasan.c
@@ -19,7 +19,6 @@
 #include <linux/string.h>
 #include <linux/uaccess.h>
 
-#include <asm/io.h>
 #include <asm/page.h>
 
 /*

which is really kinda wrong.  We should strictly include linux/io.h for
things like virt_to_phys().

So I think I'll stick with v1 plus my fixlet:

--- a/lib/test_kasan.c~lib-test_kasan-add-roundtrip-tests-checkpatch-fixes
+++ a/lib/test_kasan.c
@@ -18,8 +18,8 @@
 #include <linux/slab.h>
 #include <linux/string.h>
 #include <linux/uaccess.h>
+#include <linux/io.h>
 
-#include <asm/io.h>
 #include <asm/page.h>
 
 /*

> Since v1:
> * Spin as a separate patch
> * Fix typo
> * Note examples in commit message.

So I'm not sure what happened to these things.  Did you send the correct
patch?