linux-kernel - Re: [PATCH v4 3/4] nvme-pci: Add support for Apple 2018+ models

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190822002842.GB10391@lst.de>
Date:   Thu, 22 Aug 2019 02:28:42 +0200
From:   Christoph Hellwig <hch@....de>
To:     Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:     linux-nvme@...ts.infradead.org, Sagi Grimberg <sagi@...mberg.me>,
        Jens Axboe <axboe@...com>, Keith Busch <keith.busch@...el.com>,
        Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org,
        Paul Pawlowski <paul@...rm.io>
Subject: Re: [PATCH v4 3/4] nvme-pci: Add support for Apple 2018+ models

On Wed, Aug 07, 2019 at 05:51:21PM +1000, Benjamin Herrenschmidt wrote:
> Based on reverse engineering and original patch by
> 
> Paul Pawlowski <paul@...rm.io>
> 
> This adds support for Apple weird implementation of NVME in their
> 2018 or later machines. It accounts for the twice-as-big SQ entries
> for the IO queues, and the fact that only interrupt vector 0 appears
> to function properly.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Reviewed-by: Minwoo Im <minwoo.im.dev@...il.com>

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>