linux-kernel - Re: [PATCH] soc: imx: gpcv2: Print the correct error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <075dae8683762c2ea2bd8f7d8f539d79a0660f86.camel@nxp.com>
Date:   Thu, 22 Aug 2019 08:12:41 +0000
From:   Daniel Baluta <daniel.baluta@....com>
To:     dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "festevam@...il.com" <festevam@...il.com>,
        "agx@...xcpu.org" <agx@...xcpu.org>,
        "robh@...nel.org" <robh@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "andrew.smirnov@...il.com" <andrew.smirnov@...il.com>,
        Anson Huang <anson.huang@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
Subject: Re: [PATCH] soc: imx: gpcv2: Print the correct error code

On Wed, 2019-08-21 at 18:33 +0200, Guido Günther wrote:
> The current code prints 'ret' (thus 0) while it should use 'err'.
> 
> Signed-off-by: Guido Günther <agx@...xcpu.org>

Reviewed-by: Daniel Baluta <daniel.baluta@....com>

> ---
>  drivers/soc/imx/gpcv2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
> index 31b8d002d855..b0dffb06c05d 100644
> --- a/drivers/soc/imx/gpcv2.c
> +++ b/drivers/soc/imx/gpcv2.c
> @@ -198,7 +198,7 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct
> generic_pm_domain *genpd,
>  		err = regulator_disable(domain->regulator);
>  		if (err)
>  			dev_err(domain->dev,
> -				"failed to disable regulator: %d\n",
> ret);
> +				"failed to disable regulator: %d\n",
> err);
>  		/* Preserve earlier error code */
>  		ret = ret ?: err;
>  	}