linux-kernel - Re: [PATCH RESEND] i2c: mediatek: disable zero-length transfers for mt8183

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1566462278.26641.1.camel@mtksdaap41>
Date:   Thu, 22 Aug 2019 16:24:38 +0800
From:   Yingjoe Chen <yingjoe.chen@...iatek.com>
To:     Hsin-Yi Wang <hsinyi@...omium.org>
CC:     Wolfram Sang <wsa@...-dreams.de>,
        <linux-arm-kernel@...ts.infradead.org>,
        Nicolas Boichat <drinkcat@...omium.org>,
        Alexandru M Stan <amstan@...omium.org>,
        Jun Gao <jun.gao@...iatek.com>, <linux-kernel@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>, <linux-i2c@...r.kernel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Qii Wang <qii.wang@...iatek.com>
Subject: Re: [PATCH RESEND] i2c: mediatek: disable zero-length transfers for
 mt8183

On Thu, 2019-08-22 at 13:57 +0800, Hsin-Yi Wang wrote:
> When doing i2cdetect quick write mode, we would get transfer
> error ENOMEM, and i2cdetect shows there's no device at the address.
> Quoting from mt8183 datasheet, the number of transfers to be
> transferred in one transaction should be set to bigger than 1,
> so we should forbid zero-length transfer and update functionality.


<...>

> @@ -933,8 +942,8 @@ static int mtk_i2c_probe(struct platform_device *pdev)
>  	i2c->dev = &pdev->dev;
>  	i2c->adap.dev.parent = &pdev->dev;
>  	i2c->adap.owner = THIS_MODULE;
> -	i2c->adap.algo = &mtk_i2c_algorithm;
>  	i2c->adap.quirks = i2c->dev_comp->quirks;
> +	i2c->adap.algo = &mtk_i2c_algorithm;
>  	i2c->adap.timeout = 2 * HZ;
>  	i2c->adap.retries = 1;
>  

Why do you need to change this part?

Joe.C