linux-kernel - Re: [PATCH v7 08/14] nvmet-core: allow one host per passthru-ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b352c7f1-2629-e72f-9c85-785e0cf7c2c1@mellanox.com>
Date:   Thu, 22 Aug 2019 11:50:41 +0300
From:   Max Gurtovoy <maxg@...lanox.com>
To:     Sagi Grimberg <sagi@...mberg.me>,
        Logan Gunthorpe <logang@...tatee.com>,
        <linux-kernel@...r.kernel.org>, <linux-nvme@...ts.infradead.org>,
        <linux-block@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>
CC:     Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>,
        Stephen Bates <sbates@...thlin.com>, Jens Axboe <axboe@...com>,
        Keith Busch <kbusch@...nel.org>, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v7 08/14] nvmet-core: allow one host per passthru-ctrl


On 8/22/2019 3:09 AM, Sagi Grimberg wrote:
>
>> I don't understand why we don't limit a regular ctrl to single access 
>> and we do it for the PT ctrl.
>>
>> I guess the block layer helps to sync between multiple access in 
>> parallel but we can do it as well.
>>
>> Also, let's say you limit the access to this subsystem to 1 user, the 
>> bdev is still accessibly for local user and also you can create a 
>> different subsystem that will use this device (PT and non-PT ctrl).
>>
>> Sagi,
>>
>> can you explain the trouble you meant and how this limitation solve it ?
>
> Its different to emulate the controller with all its admin
> commands vs. passing it through to the nvme device.. (think of format 
> nvm)
>
>
>
we don't need to support format command for PT ctrl as we don't support 
other commands such create_sq/cq.