linux-kernel - Re: [PATCH V1]Perf: Return error code for perf_session_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <91b4e3c1-d2b3-c8a0-088d-1ff6466873ca@linux.vnet.ibm.com>
Date:   Thu, 22 Aug 2019 16:11:33 +0530
From:   Mamatha Inamdar <mamatha4@...ux.vnet.ibm.com>
To:     Mukesh Ojha <mojha@...eaurora.org>, linux-kernel@...r.kernel.org
Cc:     peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        namhyung@...nel.org, kstewart@...uxfoundation.org,
        gregkh@...uxfoundation.org, jeremie.galarneau@...icios.com,
        shawn@....icu, tstoyanov@...are.com, tglx@...utronix.de,
        alexey.budankov@...ux.intel.com, adrian.hunter@...el.com,
        songliubraving@...com, ravi.bangoria@...ux.ibm.com
Subject: Re: [PATCH V1]Perf: Return error code for perf_session__new function
 on failure


On 21/08/19 1:07 AM, Mukesh Ojha wrote:
>
> On 8/20/2019 4:51 PM, Mamatha Inamdar wrote:
>> This Patch is to return error code of perf_new_session function
>> on failure instead of NULL
>> ----------------------------------------------
>> Test Results:
>>
>> Before Fix:
>>
>> $ perf c2c report -input
>> failed to open nput: No such file or directory
>>
>> $ echo $?
>> 0
>> ------------------------------------------
>> After Fix:
>>
>> $ ./perf c2c report -input
>> failed to open nput: No such file or directory
>>
>> $ echo $?
>> 254
>>
>> Signed-off-by: Mamatha Inamdar <mamatha4@...ux.vnet.ibm.com>
>> Acked-by: Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
>> Reported-by: Nageswara R Sastry <rnsastry@...ux.vnet.ibm.com>
>> Tested-by: Nageswara R Sastry <rnsastry@...ux.vnet.ibm.com>
>
> Looks good to me.
>
> Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>
>
> Thanks,
> Mukesh
>
Mukesh,

Thanks for reviewing the patch..