linux-kernel - Re: [patch V2 05/38] itimers: Use quick sample function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190822121509.GI22020@lenoir>
Date:   Thu, 22 Aug 2019 14:15:09 +0200
From:   Frederic Weisbecker <frederic@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Oleg Nesterov <oleg@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        John Stultz <john.stultz@...aro.org>,
        Anna-Maria Behnsen <anna-maria@...utronix.de>,
        Christoph Hellwig <hch@....de>
Subject: Re: [patch V2 05/38] itimers: Use quick sample function

On Wed, Aug 21, 2019 at 09:08:52PM +0200, Thomas Gleixner wrote:
> get_itimer() locks sighand lock and checks whether the timer is already
> expired. If it is not expired then the thread group cputime accounting is
> already enabled. Use the sampling function not the one which is meant for
> starting a timer.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

I've always hated the abuse of thread_group_cputimer().

Thanks!

Reviewed-by: Frederic Weisbecker <frederic@...nel.org>