[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <x49h8699vfb.fsf@segfault.boston.devel.redhat.com>
Date: Thu, 22 Aug 2019 09:33:28 -0400
From: Jeff Moyer <jmoyer@...hat.com>
To: Colin King <colin.king@...onical.com>
Cc: Benjamin LaHaise <bcrl@...ck.org>,
Alexander Viro <viro@...iv.linux.org.uk>, linux-aio@...ck.org,
linux-fsdevel@...r.kernel.org, kernel-janitors@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] aio: remove redundant assignment to variable ret
Colin King <colin.king@...onical.com> writes:
> From: Colin Ian King <colin.king@...onical.com>
>
> The variable ret is being set to -EINVAL however this is never read
> and later it is being reassigned to a new value. The assignment is
> redundant and hence can be removed.
>
> Addresses-Coverity: ("Unused Value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
> fs/aio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index f9f441b59966..3e290dfac10a 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -1528,7 +1528,6 @@ static int aio_read(struct kiocb *req, const struct iocb *iocb,
> file = req->ki_filp;
> if (unlikely(!(file->f_mode & FMODE_READ)))
> return -EBADF;
> - ret = -EINVAL;
> if (unlikely(!file->f_op->read_iter))
> return -EINVAL;
Acked-by: Jeff Moyer <jmoyer@...hat.com>
Powered by blists - more mailing lists