linux-kernel - Re: [PATCH -next] drm/amdgpu: remove set but not used variable 'psp_enabled'

Open Source and information security mailing list archives

Date:   Wed, 21 Aug 2019 22:37:26 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "Wentland, Harry" <harry.wentland@....com>,
        tiancyin <tianci.yin@....com>, Tao Zhou <tao.zhou1@....com>,
        Leo Liu <leo.liu@....com>, Huang Rui <ray.huang@....com>,
        Jack Xiao <Jack.Xiao@....com>,
        Hawking Zhang <Hawking.Zhang@....com>,
        Kenneth Feng <kenneth.feng@....com>,
        kernel-janitors@...r.kernel.org,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/amdgpu: remove set but not used variable 'psp_enabled'

Applied.  thanks!

Alex

On Thu, Jun 27, 2019 at 10:29 AM YueHaibing <yuehaibing@...wei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/amd/amdgpu/nv.c: In function 'nv_common_early_init':
> drivers/gpu/drm/amd/amdgpu/nv.c:471:7: warning:
>  variable 'psp_enabled' set but not used [-Wunused-but-set-variable]
>
> It's not used since inroduction in
> commit c6b6a42175f5 ("drm/amdgpu: add navi10 common ip block (v3)")
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/nv.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c
> index af20ffb55c54..8b9fa3db8daa 100644
> --- a/drivers/gpu/drm/amd/amdgpu/nv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/nv.c
> @@ -468,7 +468,6 @@ static const struct amdgpu_asic_funcs nv_asic_funcs =
>
>  static int nv_common_early_init(void *handle)
>  {
> -       bool psp_enabled = false;
>         struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>
>         adev->smc_rreg = NULL;
> @@ -485,10 +484,6 @@ static int nv_common_early_init(void *handle)
>
>         adev->asic_funcs = &nv_asic_funcs;
>
> -       if (amdgpu_device_ip_get_ip_block(adev, AMD_IP_BLOCK_TYPE_PSP) &&
> -           (amdgpu_ip_block_mask & (1 << AMD_IP_BLOCK_TYPE_PSP)))
> -               psp_enabled = true;
> -
>         adev->rev_id = nv_get_rev_id(adev);
>         adev->external_rev_id = 0xff;
>         switch (adev->asic_type) {
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives