linux-kernel - Re: [PATCH] drm/msm/dpu: add rotation property

Open Source and information security mailing list archives

Message-ID: <CAF6AEGv4=PTJtD6au1=j-fe0BaDMsDHW0dTe+-GojOD1sh+o+Q@mail.gmail.com>
Date:   Thu, 22 Aug 2019 08:45:34 -0700
From:   Rob Clark <robdclark@...il.com>
To:     Ville Syrjälä <ville.syrjala@...ux.intel.com>
Cc:     dri-devel <dri-devel@...ts.freedesktop.org>,
        Rob Clark <robdclark@...omium.org>,
        freedreno <freedreno@...ts.freedesktop.org>,
        Fritz Koenig <frkoenig@...gle.com>,
        David Airlie <airlied@...ux.ie>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bruce Wang <bzwang@...omium.org>, Sean Paul <sean@...rly.run>
Subject: Re: [PATCH] drm/msm/dpu: add rotation property

On Thu, Aug 22, 2019 at 5:26 AM Ville Syrjälä
<ville.syrjala@...ux.intel.com> wrote:
>
> On Wed, Aug 21, 2019 at 06:57:24PM -0700, Rob Clark wrote:
> > From: Rob Clark <robdclark@...omium.org>
> >
> > Signed-off-by: Rob Clark <robdclark@...omium.org>
> > ---
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> > index 45bfac9e3af7..c5653771e8fa 100644
> > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> > @@ -1040,8 +1040,21 @@ static void dpu_plane_sspp_atomic_update(struct drm_plane *plane)
> >                               pstate->multirect_mode);
> >
> >       if (pdpu->pipe_hw->ops.setup_format) {
> > +             unsigned int rotation;
> > +
> >               src_flags = 0x0;
> >
> > +             rotation = drm_rotation_simplify(state->rotation,
> > +                                              DRM_MODE_ROTATE_0 |
> > +                                              DRM_MODE_REFLECT_X |
> > +                                              DRM_MODE_REFLECT_Y);
> > +
> > +             if (rotation & DRM_MODE_REFLECT_X)
> > +                     src_flags |= DPU_SSPP_FLIP_UD;
> > +
> > +             if (rotation & DRM_MODE_REFLECT_Y)
> > +                     src_flags |= DPU_SSPP_FLIP_LR;
> > +
>
> UD vs. LR (assuming those mean what I think they mean) seem the wrong
> way around here.

ahh, right, reflect "along" vs "around"..

BR,
-R

>
> >
> >               /* update format */
> >               pdpu->pipe_hw->ops.setup_format(pdpu->pipe_hw, fmt, src_flags,
> >                               pstate->multirect_index);
> > @@ -1522,6 +1535,13 @@ struct drm_plane *dpu_plane_init(struct drm_device *dev,
> >       if (ret)
> >               DPU_ERROR("failed to install zpos property, rc = %d\n", ret);
> >
> > +     drm_plane_create_rotation_property(plane,
> > +                     DRM_MODE_ROTATE_0,
> > +                     DRM_MODE_ROTATE_0 |
> > +                     DRM_MODE_ROTATE_180 |
> > +                     DRM_MODE_REFLECT_X |
> > +                     DRM_MODE_REFLECT_Y);
> > +
> >       drm_plane_enable_fb_damage_clips(plane);
> >
> >       /* success! finalize initialization */
> > --
> > 2.21.0
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@...ts.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Ville Syrjälä
> Intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives