linux-kernel - Re: [PATCH 1/2] riscv: Add memmove string operation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09d5108e-f0ba-13d3-be9e-119f49f6bd85@virtuozzo.com>
Date:   Thu, 22 Aug 2019 18:59:02 +0300
From:   Andrey Ryabinin <aryabinin@...tuozzo.com>
To:     Nick Hu <nickhu@...estech.com>, alankao@...estech.com,
        paul.walmsley@...ive.com, palmer@...ive.com, aou@...s.berkeley.edu,
        green.hu@...il.com, deanbo422@...il.com, tglx@...utronix.de,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        glider@...gle.com, dvyukov@...gle.com, Anup.Patel@....com,
        gregkh@...uxfoundation.org, alexios.zavras@...el.com,
        atish.patra@....com, zong@...estech.com, kasan-dev@...glegroups.com
Subject: Re: [PATCH 1/2] riscv: Add memmove string operation.

On 8/7/19 10:19 AM, Nick Hu wrote:
> There are some features which need this string operation for compilation,
> like KASAN. So the purpose of this porting is for the features like KASAN
> which cannot be compiled without it.
> 

Compilation error can be fixed by diff bellow (I didn't test it).
If you don't need memmove very early (before kasan_early_init()) than arch-specific not-instrumented memmove()
isn't necessary to have.

---
 mm/kasan/common.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/kasan/common.c b/mm/kasan/common.c
index 6814d6d6a023..897f9520bab3 100644
--- a/mm/kasan/common.c
+++ b/mm/kasan/common.c
@@ -107,6 +107,7 @@ void *memset(void *addr, int c, size_t len)
 	return __memset(addr, c, len);
 }
 
+#ifdef __HAVE_ARCH_MEMMOVE
 #undef memmove
 void *memmove(void *dest, const void *src, size_t len)
 {
@@ -115,6 +116,7 @@ void *memmove(void *dest, const void *src, size_t len)
 
 	return __memmove(dest, src, len);
 }
+#endif
 
 #undef memcpy
 void *memcpy(void *dest, const void *src, size_t len)
-- 
2.21.0