[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CADnq5_PcbKZDsqmoL2wK061sL=KfCedmEafn_hpbFZ9tNGrNdA@mail.gmail.com>
Date: Wed, 21 Aug 2019 22:43:31 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: YueHaibing <yuehaibing@...wei.com>
Cc: Oded Gabbay <oded.gabbay@...il.com>,
"Deucher, Alexander" <alexander.deucher@....com>,
Christian Koenig <christian.koenig@....com>,
Chunming Zhou <David1.Zhou@....com>,
Dave Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Maling list - DRI developers
<dri-devel@...ts.freedesktop.org>,
LKML <linux-kernel@...r.kernel.org>,
amd-gfx list <amd-gfx@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/amdkfd: remove set but not used variable 'pdd'
Applied. thanks!
Alex
On Fri, Jul 26, 2019 at 11:58 AM YueHaibing <yuehaibing@...wei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c: In function restore_process_worker:
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:949:29: warning:
> variable pdd set but not used [-Wunused-but-set-variable]
>
> It is not used since
> commit 5b87245faf57 ("drm/amdkfd: Simplify kfd2kgd interface")
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_process.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index 8f1076c..240bf68 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -1042,7 +1042,6 @@ static void restore_process_worker(struct work_struct *work)
> {
> struct delayed_work *dwork;
> struct kfd_process *p;
> - struct kfd_process_device *pdd;
> int ret = 0;
>
> dwork = to_delayed_work(work);
> @@ -1051,16 +1050,6 @@ static void restore_process_worker(struct work_struct *work)
> * lifetime of this thread, kfd_process p will be valid
> */
> p = container_of(dwork, struct kfd_process, restore_work);
> -
> - /* Call restore_process_bos on the first KGD device. This function
> - * takes care of restoring the whole process including other devices.
> - * Restore can fail if enough memory is not available. If so,
> - * reschedule again.
> - */
> - pdd = list_first_entry(&p->per_device_data,
> - struct kfd_process_device,
> - per_device_list);
> -
> pr_debug("Started restoring pasid %d\n", p->pasid);
>
> /* Setting last_restore_timestamp before successful restoration.
> --
> 2.7.4
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Powered by blists - more mailing lists