linux-kernel - Re: [PATCH] cpufreq: Print driver name if cpufreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b534e21b-af00-bbec-2a53-0c3bda8c8ce9@gmail.com>
Date:   Thu, 22 Aug 2019 09:21:20 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "open list:CPU FREQUENCY SCALING FRAMEWORK" 
        <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: Print driver name if cpufreq_suspend() fails

On 8/21/19 7:42 PM, Viresh Kumar wrote:
> On 21-08-19, 16:16, Florian Fainelli wrote:
>> Instead of printing the policy, which is incidentally a kernel pointer,
>> so with limited interest, print the cpufreq driver name that failed to
>> be suspend, which is more useful for debugging.
>>
>> Fixes: 2f0aea936360 ("cpufreq: suspend governors on system suspend/hibernate")
> 
> I will drop this tag as this isn't a bug really.

Indeed, that was a bit too trigger happy on my side. Thanks!

> 
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
>> ---
>>  drivers/cpufreq/cpufreq.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
>> index c28ebf2810f1..330d789f81fc 100644
>> --- a/drivers/cpufreq/cpufreq.c
>> +++ b/drivers/cpufreq/cpufreq.c
>> @@ -1807,8 +1807,8 @@ void cpufreq_suspend(void)
>>  		}
>>  
>>  		if (cpufreq_driver->suspend && cpufreq_driver->suspend(policy))
>> -			pr_err("%s: Failed to suspend driver: %p\n", __func__,
>> -				policy);
>> +			pr_err("%s: Failed to suspend driver: %s\n", __func__,
>> +				cpufreq_driver->name);
>>  	}
>>  
>>  suspend:
> 
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> 


-- 
Florian