linux-kernel - Re: [PATCH] [media] pvrusb2: qctrl.flag will be uninitlaized if cx2341x_ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Aug 2019 09:31:53 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Yizhuo <yzhai003@....edu>
Cc:     kbuild-all@...org, csong@...ucr.edu, zhiyunq@...ucr.edu,
        Yizhuo <yzhai003@....edu>, Mike Isely <isely@...ox.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [media] pvrusb2: qctrl.flag will be uninitlaized if
 cx2341x_ctrl_query() returns error code

Hi Yizhuo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[cannot apply to v5.3-rc5 next-20190822]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Yizhuo/pvrusb2-qctrl-flag-will-be-uninitlaized-if-cx2341x_ctrl_query-returns-error-code/20190823-075303
base:   git://linuxtv.org/media_tree.git master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/media/usb/pvrusb2/pvrusb2-hdw.c: In function 'ctrl_cx2341x_getv4lflags':
>> drivers/media/usb/pvrusb2/pvrusb2-hdw.c:790:10: error: 'qctr' undeclared (first use in this function); did you mean 'qctrl'?
     memset(&qctr, 0, sizeof(qctrl))
             ^~~~
             qctrl
   drivers/media/usb/pvrusb2/pvrusb2-hdw.c:790:10: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/media/usb/pvrusb2/pvrusb2-hdw.c:791:2: error: expected ';' before 'cx2341x_ctrl_query'
     cx2341x_ctrl_query(&cptr->hdw->enc_ctl_state,&qctrl);
     ^~~~~~~~~~~~~~~~~~

vim +790 drivers/media/usb/pvrusb2/pvrusb2-hdw.c

   784	
   785	static unsigned int ctrl_cx2341x_getv4lflags(struct pvr2_ctrl *cptr)
   786	{
   787		struct v4l2_queryctrl qctrl;
   788		struct pvr2_ctl_info *info;
   789		qctrl.id = cptr->info->v4l_id;
 > 790		memset(&qctr, 0, sizeof(qctrl))
 > 791		cx2341x_ctrl_query(&cptr->hdw->enc_ctl_state,&qctrl);
   792		/* Strip out the const so we can adjust a function pointer.  It's
   793		   OK to do this here because we know this is a dynamically created
   794		   control, so the underlying storage for the info pointer is (a)
   795		   private to us, and (b) not in read-only storage.  Either we do
   796		   this or we significantly complicate the underlying control
   797		   implementation. */
   798		info = (struct pvr2_ctl_info *)(cptr->info);
   799		if (qctrl.flags & V4L2_CTRL_FLAG_READ_ONLY) {
   800			if (info->set_value) {
   801				info->set_value = NULL;
   802			}
   803		} else {
   804			if (!(info->set_value)) {
   805				info->set_value = ctrl_cx2341x_set;
   806			}
   807		}
   808		return qctrl.flags;
   809	}
   810	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (51782 bytes)