linux-kernel - Re: [RFC PATCH] iommu/vt-d: Fix IOMMU field not populated on device hot re-plug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00f1a3a7-7ff6-e9a0-d9de-a177af6fd64b@linux.intel.com>
Date:   Fri, 23 Aug 2019 09:51:11 +0800
From:   Lu Baolu <baolu.lu@...ux.intel.com>
To:     Janusz Krzysztofik <janusz.krzysztofik@...ux.intel.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Joerg Roedel <joro@...tes.org>
Cc:     baolu.lu@...ux.intel.com, iommu@...ts.linux-foundation.org,
        intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Michał Wajdeczko <michal.wajdeczko@...el.com>
Subject: Re: [RFC PATCH] iommu/vt-d: Fix IOMMU field not populated on device
 hot re-plug

Hi,

On 8/22/19 10:29 PM, Janusz Krzysztofik wrote:
> When a perfectly working i915 device is hot unplugged (via sysfs) and
> hot re-plugged again, its dev->archdata.iommu field is not populated
> again with an IOMMU pointer.  As a result, the device probe fails on
> DMA mapping error during scratch page setup.
> 
> It looks like that happens because devices are not detached from their
> MMUIO bus before they are removed on device unplug.  Then, when an
> already registered device/IOMMU association is identified by the
> reinstantiated device's bus and function IDs on IOMMU bus re-attach
> attempt, the device's archdata is not populated with IOMMU information
> and the bad happens.
> 
> I'm not sure if this is a proper fix but it works for me so at least it
> confirms correctness of my analysis results, I believe.  So far I
> haven't been able to identify a good place where the possibly missing
> IOMMU bus detach on device unplug operation could be added.

Which kernel version are you testing with? Does it contain below commit?

commit 458b7c8e0dde12d140e3472b80919cbb9ae793f4
Author: Lu Baolu <baolu.lu@...ux.intel.com>
Date:   Thu Aug 1 11:14:58 2019 +0800

     iommu/vt-d: Detach domain when move device out of group

     When removing a device from an iommu group, the domain should
     be detached from the device. Otherwise, the stale domain info
     will still be cached by the driver and the driver will refuse
     to attach any domain to the device again.

     Cc: Ashok Raj <ashok.raj@...el.com>
     Cc: Jacob Pan <jacob.jun.pan@...ux.intel.com>
     Cc: Kevin Tian <kevin.tian@...el.com>
     Fixes: b7297783c2bb6 ("iommu/vt-d: Remove duplicated code for 
device hotplug")
     Reported-and-tested-by: Vlad Buslov <vladbu@...lanox.com>
     Suggested-by: Robin Murphy <robin.murphy@....com>
     Link: https://lkml.org/lkml/2019/7/26/1133
     Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>
     Signed-off-by: Joerg Roedel <jroedel@...e.de>

Best regards,
Lu Baolu

> 
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@...ux.intel.com>
> ---
>   drivers/iommu/intel-iommu.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 12d094d08c0a..7cdcd0595408 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -2477,6 +2477,9 @@ static struct dmar_domain *dmar_insert_one_dev_info(struct intel_iommu *iommu,
>   		if (info2) {
>   			found      = info2->domain;
>   			info2->dev = dev;
> +
> +			if (dev && !dev->archdata.iommu)
> +				dev->archdata.iommu = info2;
>   		}
>   	}
>   
>