linux-kernel - Re: [PATCH v6] ata/pata_buddha: Probe via modalias instead of initcall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cc15fb71-0e83-5b53-eb5f-f276f8718a4e@enpas.org>
Date:   Fri, 23 Aug 2019 12:47:59 +0200
From:   Max Staudt <max@...as.org>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     axboe@...nel.dk, linux-ide@...r.kernel.org,
        linux-m68k@...r.kernel.org, linux-kernel@...r.kernel.org,
        glaubitz@...sik.fu-berlin.de, schmitzmic@...il.com,
        geert@...ux-m68k.org
Subject: Re: [PATCH v6] ata/pata_buddha: Probe via modalias instead of
 initcall

On 08/23/2019 12:42 PM, Bartlomiej Zolnierkiewicz wrote:
>> +static struct zorro_driver pata_buddha_driver = {
>> +	.name           = "pata_buddha",
>> +	.id_table       = pata_buddha_zorro_tbl,
>> +	.probe          = pata_buddha_probe,
>> +	.remove         = pata_buddha_remove,
>> +	.driver  = {
>> +		.suppress_bind_attrs = true,
> 
> I thought that we had agreed that this is not needed?

You're right, that slipped in. Thanks for catching it!

I'll send a v7 i two minutes, and would be grateful if you could ACK it.


Max