linux-kernel - Re: [PATCH -next] rtc: pcf2127: Fix build error without CONFIG_WATCHDOG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1a11d06-ce3a-d289-2a61-607ba8e0509f@roeck-us.net>
Date:   Fri, 23 Aug 2019 06:38:17 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     YueHaibing <yuehaibing@...wei.com>, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, bruno.thomsen@...il.com
Cc:     linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] rtc: pcf2127: Fix build error without
 CONFIG_WATCHDOG_CORE

On 8/23/19 5:45 AM, YueHaibing wrote:
> If WATCHDOG_CORE is not set, build fails:
> 
> drivers/rtc/rtc-pcf2127.o: In function `pcf2127_probe.isra.6':
> drivers/rtc/rtc-pcf2127.c:478: undefined reference to `devm_watchdog_register_device'
> 
> Add WATCHDOG_CORE Kconfig dependency to fix this.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: bbc597561ce1 ("rtc: pcf2127: add watchdog feature support")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/rtc/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 25af63d..9dce7dc 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -886,6 +886,8 @@ config RTC_DRV_DS3232_HWMON
>   config RTC_DRV_PCF2127
>   	tristate "NXP PCF2127"
>   	depends on RTC_I2C_AND_SPI
> +	depends on WATCHDOG
> +	select WATCHDOG_CORE
>   	help
>   	  If you say yes here you get support for the NXP PCF2127/29 RTC
>   	  chips with integrated quartz crystal for industrial applications.
>