linux-kernel - Re: [PATCH] drm/komeda: Add missing of_node_get() call

Open Source and information security mailing list archives

Message-ID: <20190823134348.GA27922@arm.com>
Date:   Fri, 23 Aug 2019 13:43:49 +0000
From:   Ayan Halder <Ayan.Halder@....com>
To:     Mihail Atanassov <Mihail.Atanassov@....com>
CC:     David Airlie <airlied@...ux.ie>, Liviu Dudau <Liviu.Dudau@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "james qian wang (Arm Technology China)" <james.qian.wang@....com>,
        nd <nd@....com>
Subject: Re: [PATCH] drm/komeda: Add missing of_node_get() call

On Tue, Aug 20, 2019 at 03:16:58PM +0000, Mihail Atanassov wrote:
> komeda_pipeline_destroy has the matching of_node_put().
> 
> Fixes: 29e56aec911dd ("drm/komeda: Add DT parsing")
> Signed-off-by: Mihail Atanassov <mihail.atanassov@....com>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index 0142ee991957..ca64a129c594 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -130,7 +130,7 @@ static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np)
>  		of_graph_get_port_by_id(np, KOMEDA_OF_PORT_OUTPUT);
>  
>  	pipe->dual_link = pipe->of_output_links[0] && pipe->of_output_links[1];
> -	pipe->of_node = np;
> +	pipe->of_node = of_node_get(np);
>  

Good catch.
Reviewed-by: Ayan Kumar Halder <ayan.halder@....com>
>  	return 0;
>  }
> -- 
> 2.22.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives