linux-kernel - Re: [PATCH 2/2] fbdev: fbmem: allow overriding the number of bootup logos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4194b690-027f-be16-dc4e-299643e75b83@axentia.se>
Date:   Sun, 25 Aug 2019 09:35:52 +0000
From:   Peter Rosin <peda@...ntia.se>
To:     Matthew Wilcox <willy@...radead.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Jonathan Corbet <corbet@....net>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH 2/2] fbdev: fbmem: allow overriding the number of bootup
 logos

On 2019-08-24 17:34, Matthew Wilcox wrote:
> On Fri, Aug 23, 2019 at 08:47:47AM +0000, Peter Rosin wrote:
>> +++ b/drivers/video/fbdev/core/fbcon.c
>> +++ b/drivers/video/fbdev/core/fbmem.c
>> @@ -56,6 +56,9 @@ EXPORT_SYMBOL(num_registered_fb);
>>  bool fb_center_logo __read_mostly;
>>  EXPORT_SYMBOL(fb_center_logo);
>>  
>> +unsigned int fb_logo_count __read_mostly;
>> +EXPORT_SYMBOL(fb_logo_count);
> 
> Why does this symbol need to be exported?  As I read the Makefile, fbcon
> and fbmem are combined into the same module, so while the symbol needs
> to be non-static, it doesn't need to be exported to other modules.

I guess you are right. I'll send a v2 tomorrow with an added patch to
unexport the fb_center_logo variable while at it...

Thanks for the feedback.

Cheers,
Peter