linux-kernel - Re: [greybus-dev] [PATCH 5/9] staging: greybus: log: Fix up some alignment checkpatch issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Aug 2019 11:42:35 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org, greybus-dev@...ts.linaro.org,
        elder@...nel.org, johan@...nel.org, linux-kernel@...r.kernel.org,
        David Lin <dtwlin@...il.com>
Subject: Re: [greybus-dev] [PATCH 5/9] staging: greybus: log: Fix up some
 alignment checkpatch issues

On 25-08-19, 07:54, Greg Kroah-Hartman wrote:
> Some function prototypes do not match the expected alignment formatting
> so fix that up so that checkpatch is happy.
> 
> Cc: David Lin <dtwlin@...il.com>
> Cc: Johan Hovold <johan@...nel.org>
> Cc: Alex Elder <elder@...nel.org>
> Cc: greybus-dev@...ts.linaro.org
> Cc: devel@...verdev.osuosl.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/staging/greybus/log.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/greybus/log.c b/drivers/staging/greybus/log.c
> index 15a88574dbb0..4f1f161ff11c 100644
> --- a/drivers/staging/greybus/log.c
> +++ b/drivers/staging/greybus/log.c
> @@ -31,14 +31,14 @@ static int gb_log_request_handler(struct gb_operation *op)
>  	/* Verify size of payload */
>  	if (op->request->payload_size < sizeof(*receive)) {
>  		dev_err(dev, "log request too small (%zu < %zu)\n",
> -				op->request->payload_size, sizeof(*receive));
> +			op->request->payload_size, sizeof(*receive));
>  		return -EINVAL;
>  	}
>  	receive = op->request->payload;
>  	len = le16_to_cpu(receive->len);
>  	if (len != (op->request->payload_size - sizeof(*receive))) {
>  		dev_err(dev, "log request wrong size %d vs %zu\n", len,
> -				(op->request->payload_size - sizeof(*receive)));
> +			(op->request->payload_size - sizeof(*receive)));
>  		return -EINVAL;
>  	}
>  	if (len == 0) {
> @@ -83,7 +83,7 @@ static int gb_log_probe(struct gb_bundle *bundle,
>  		return -ENOMEM;
>  
>  	connection = gb_connection_create(bundle, le16_to_cpu(cport_desc->id),
> -			gb_log_request_handler);
> +					  gb_log_request_handler);
>  	if (IS_ERR(connection)) {
>  		retval = PTR_ERR(connection);
>  		goto error_free;

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh