linux-kernel - Re: [PATCH v2 10/11] arm64: edit zone_dma_bits to fine tune dma-direct min mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190826070633.GB11331@lst.de>
Date:   Mon, 26 Aug 2019 09:06:33 +0200
From:   Christoph Hellwig <hch@....de>
To:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Cc:     catalin.marinas@....com, hch@....de, wahrenst@....net,
        marc.zyngier@....com, robh+dt@...nel.org,
        Robin Murphy <robin.murphy@....com>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-arch@...r.kernel.org, iommu@...ts.linux-foundation.org,
        linux-mm@...ck.org, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, phill@...pberryi.org,
        f.fainelli@...il.com, will@...nel.org, eric@...olt.net,
        mbrugger@...e.com, linux-rpi-kernel@...ts.infradead.org,
        akpm@...ux-foundation.org, frowand.list@...il.com,
        m.szyprowski@...sung.com
Subject: Re: [PATCH v2 10/11] arm64: edit zone_dma_bits to fine tune
 dma-direct min mask

On Tue, Aug 20, 2019 at 04:58:18PM +0200, Nicolas Saenz Julienne wrote:
> -	if (IS_ENABLED(CONFIG_ZONE_DMA))
> +	if (IS_ENABLED(CONFIG_ZONE_DMA)) {
>  		arm64_dma_phys_limit = max_zone_dma_phys();
> +		zone_dma_bits = ilog2((arm64_dma_phys_limit - 1) & GENMASK_ULL(31, 0)) + 1;

This adds a way too long line.  I also find the use of GENMASK_ULL
horribly obsfucating, but I know that opinion is't shared by everyone.