linux-kernel - Re: [PATCH] iio: imu: st_lsm6dsx: Fix FIFO diff mask for tagged fifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 26 Aug 2019 09:58:02 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     Mario Tesi <martepisa@...il.com>, lorenzo.bianconi83@...il.com,
        knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        mario.tesi@...com
Subject: Re: [PATCH] iio: imu: st_lsm6dsx: Fix FIFO diff mask for tagged
 fifo

On Mon, 26 Aug 2019 10:22:20 +0200
Lorenzo Bianconi <lorenzo@...nel.org> wrote:

> > On Thu, 22 Aug 2019 15:22:19 +0200
> > Mario Tesi <martepisa@...il.com> wrote:
> >   
> > > From: mario tesi <mario.tesi@...com>
> > > 
> > > 	According to the latest version of datasheet the mask
> > > 	for number of unread sensor data in FIFO_STATUS registers
> > > 	has been extended to 10 bits
> > > 
> > > 	The devices involved are:
> > > 	 - LSM6DSO
> > > 	 - LSM6DSOX
> > > 	 - ASM330LHH
> > > 	 - LSM6DSR
> > > 	 - ISM330DHCX
> > > 
> > > Signed-off-by: mario tesi <mario.tesi@...com>  
> > 
> > Seems straight forward and should be side effect free I think.
> > Hence I won't wait for Lorenzo to take a look (though there
> > is still a small window for comments whilst the autobuilders
> > poke at it!)
> > 
> > Applied to the togreg branch of iio.git and pushed out as testing
> > for the autobuilders to take a look.
> > 
> > Thanks,  
> 
> Acked-by: Lorenzo Bianconi <lorenzo@...nel.org>

Nice. That was fast enough that I haven't applied any patches on
top of Mario's yet so a quick git --amend job ;)

Thanks,

Jonathan

> 
> > 
> > Jonathan
> >   
> > > ---
> > >  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > index 85824d6..47b77d0 100644
> > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > @@ -497,7 +497,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
> > >  			},
> > >  			.fifo_diff = {
> > >  				.addr = 0x3a,
> > > -				.mask = GENMASK(8, 0),
> > > +				.mask = GENMASK(9, 0),
> > >  			},
> > >  			.th_wl = 1,
> > >  		},
> > > @@ -623,7 +623,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
> > >  			},
> > >  			.fifo_diff = {
> > >  				.addr = 0x3a,
> > > -				.mask = GENMASK(8, 0),
> > > +				.mask = GENMASK(9, 0),
> > >  			},
> > >  			.th_wl = 1,
> > >  		},
> > > @@ -726,7 +726,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
> > >  			},
> > >  			.fifo_diff = {
> > >  				.addr = 0x3a,
> > > -				.mask = GENMASK(8, 0),
> > > +				.mask = GENMASK(9, 0),
> > >  			},
> > >  			.th_wl = 1,
> > >  		},  
> >