linux-kernel - Re: [PATCH v4 3/8] PM/sleep: Replace strncmp with str_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13649784.SkF4frceZu@kreacher>
Date:   Mon, 26 Aug 2019 11:19:12 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Chuhong Yuan <hslester96@...il.com>
Cc:     Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/8] PM/sleep: Replace strncmp with str_has_prefix

On Friday, August 9, 2019 9:10:23 AM CEST Chuhong Yuan wrote:
> strncmp(str, const, len) is error-prone because len
> is easy to have typo.
> The example is the hard-coded len has counting error
> or sizeof(const) forgets - 1.
> So we prefer using newly introduced str_has_prefix()
> to substitute such strncmp to make code better.
> 
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>
> ---
>  kernel/power/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index bdbd605c4215..5e5f64bb3a43 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c
> @@ -495,7 +495,7 @@ static suspend_state_t decode_state(const char *buf, size_t n)
>  	len = p ? p - buf : n;
>  
>  	/* Check hibernation first. */
> -	if (len == 4 && !strncmp(buf, "disk", len))
> +	if (len == 4 && str_has_prefix(buf, "disk"))
>  		return PM_SUSPEND_MAX;
>  
>  #ifdef CONFIG_SUSPEND
> 

Applied, thanks!