[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ef91f93a-89d9-e49b-e9f3-dd5a9cd98b91@ti.com>
Date: Mon, 26 Aug 2019 17:37:56 +0530
From: Vignesh Raghavendra <vigneshr@...com>
To: Anil Varughese <aniljoy@...ence.com>, <alim.akhtar@...sung.com>,
<avri.altman@....com>, <pedrom.sousa@...opsys.com>
CC: <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>, <hare@...e.de>,
<rafalc@...ence.com>, <mparab@...ence.com>, <jank@...ence.com>,
<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] scsi: ufs: Disable local LCC in .link_startup_notify()
in Cadence UFS
Hi,
On 13/08/19 1:12 PM, Anil Varughese wrote:
> Some UFS devices have issues if LCC is enabled. So we
> are setting PA_LOCAL_TX_LCC_Enable to 0 before link
> startup which will make sure that both host and device
> TX LCC are disabled once link startup is completed.
>
> Signed-off-by: Anil Varughese <aniljoy@...ence.com>> ---
Reviewed-by: Vignesh Raghavendra <vigneshr@...com>
Regards
Vignesh
> drivers/scsi/ufs/cdns-pltfrm.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/scsi/ufs/cdns-pltfrm.c b/drivers/scsi/ufs/cdns-pltfrm.c
> index 993519080..b2af04c57 100644
> --- a/drivers/scsi/ufs/cdns-pltfrm.c
> +++ b/drivers/scsi/ufs/cdns-pltfrm.c
> @@ -77,6 +77,31 @@ static int cdns_ufs_hce_enable_notify(struct ufs_hba *hba,
> return cdns_ufs_set_hclkdiv(hba);
> }
>
> +/**
> + * Called before and after Link startup is carried out.
> + * @hba: host controller instance
> + * @status: notify stage (pre, post change)
> + *
> + * Return zero for success and non-zero for failure
> + */
> +static int cdns_ufs_link_startup_notify(struct ufs_hba *hba,
> + enum ufs_notify_change_status status)
> +{
> + if (status != PRE_CHANGE)
> + return 0;
> +
> + /*
> + * Some UFS devices have issues if LCC is enabled.
> + * So we are setting PA_Local_TX_LCC_Enable to 0
> + * before link startup which will make sure that both host
> + * and device TX LCC are disabled once link startup is
> + * completed.
> + */
> + ufshcd_dme_set(hba, UIC_ARG_MIB(PA_LOCAL_TX_LCC_ENABLE), 0);
> +
> + return 0;
> +}
> +
> /**
> * cdns_ufs_init - performs additional ufs initialization
> * @hba: host controller instance
> @@ -114,12 +139,14 @@ static int cdns_ufs_m31_16nm_phy_initialization(struct ufs_hba *hba)
> static const struct ufs_hba_variant_ops cdns_ufs_pltfm_hba_vops = {
> .name = "cdns-ufs-pltfm",
> .hce_enable_notify = cdns_ufs_hce_enable_notify,
> + .link_startup_notify = cdns_ufs_link_startup_notify,
> };
>
> static const struct ufs_hba_variant_ops cdns_ufs_m31_16nm_pltfm_hba_vops = {
> .name = "cdns-ufs-pltfm",
> .init = cdns_ufs_init,
> .hce_enable_notify = cdns_ufs_hce_enable_notify,
> + .link_startup_notify = cdns_ufs_link_startup_notify,
> .phy_initialization = cdns_ufs_m31_16nm_phy_initialization,
> };
>
>
--
Regards
Vignesh
Powered by blists - more mailing lists