linux-kernel - Re: [PATCH RESEND] erofs: fix compile warnings when moving out include/trace/events/erofs.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190826142624.GA22424@hsiangkao-HP-ZHAN-66-Pro-G1>
Date:   Mon, 26 Aug 2019 22:26:26 +0800
From:   Gao Xiang <hsiangkao@....com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Chao Yu <chao@...nel.org>
Cc:     Gao Xiang <gaoxiang25@...wei.com>, Chao Yu <yuchao0@...wei.com>,
        devel@...verdev.osuosl.org,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        linux-erofs@...ts.ozlabs.org, LKML <linux-kernel@...r.kernel.org>,
        weidu.du@...wei.com, Fang Wei <fangwei1@...wei.com>,
        Miao Xie <miaoxie@...wei.com>
Subject: Re: [PATCH RESEND] erofs: fix compile warnings when moving out
 include/trace/events/erofs.h

Hi Chao,

On Mon, Aug 26, 2019 at 09:51:35PM +0800, Chao Yu wrote:
> On 2019-8-26 21:26, Gao Xiang wrote:

[]

> >  TRACE_EVENT(erofs_lookup,
> >  ^~~~~~~~~~~
> > include/trace/events/erofs.h:28:2: note: in expansion of macro 'TP_PROTO'
> >   TP_PROTO(struct inode *dir, struct dentry *dentry, unsigned int flags),
> >   ^~~~~~~~
> > 
> > That makes me very confused since most original EROFS tracepoint code
> > was taken from f2fs, and finally I found
> > 
> > commit 43c78d88036e ("kbuild: compile-test kernel headers to ensure they are self-contained")
> > 
> > It seems these warnings are generated from KERNEL_HEADER_TEST feature and
> > ext4/f2fs tracepoint files were in blacklist.
> 
> For f2fs.h, it will be only used by f2fs module, I guess it's okay to let it
> stay in blacklist...


Yes, it depends on you f2fs folks selection...
Anyway, this file is a new file, therefore it should be better not to add to
blacklist...


> 
> > 
> > Anyway, let's fix these issues for KERNEL_HEADER_TEST feature instead
> > of adding to blacklist...
> > 
> > [1] https://lore.kernel.org/lkml/20190826162432.11100665@canb.auug.org.au/
> > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > Signed-off-by: Gao Xiang <gaoxiang25@...wei.com>
> 
> Reviewed-by: Chao Yu <yuchao0@...wei.com>


Thanks for reviewing :)


Thanks,
Gao Xiang

> 
> Thanks,