linux-kernel - Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Aug 2019 14:45:40 +0000
From:   Leonard Crestez <leonard.crestez@....com>
To:     Anson Huang <anson.huang@....com>,
        Eduardo Valentin <edubezval@...il.com>,
        Shawn Guo <shawnguo@...nel.org>
CC:     Zhang Rui <rui.zhang@...el.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        Stephen Boyd <sboyd@...nel.org>,
        Andrey Smirnov <andrew.smirnov@...il.com>
Subject: Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

On 7/30/2019 5:31 AM, Anson.Huang@....com wrote:
> From: Anson Huang <Anson.Huang@....com>
> 
> Some platforms like i.MX8MQ has clock control for this module,
> need to add clock operations to make sure the driver is working
> properly.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> Reviewed-by: Guido Günther <agx@...xcpu.org>

This series looks good, do you think it can be merged in time for v5.4? 
Today was v5.3-rc6.

In an earlier series the CLK_IS_CRITICAL flags was removed from the TMU 
clock so if the thermal driver doesn't explicitly enable it the system 
will hang on probe. This is what happens in linux-next right now!

Unless this patches is merged soon we'll end up with a 5.4-rc1 that 
doesn't boot on imx8mq. An easy fix would be to drop/revert commit 
951c1aef9691 ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for 
IMX8MQ_CLK_TMU_ROOT") until the thermal patches are accepted.

Merging patches out-of-order when they have hard (boot-breaking) 
dependencies also breaks bisect.

--
Regards,
Leonard