linux-kernel - Re: [PATCH] perf script: Fix memory leaks in list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 26 Aug 2019 10:59:47 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf script: Fix memory leaks in list_scripts()



On 8/26/19 9:07 AM, Arnaldo Carvalho de Melo wrote:
> Em Sun, Aug 25, 2019 at 11:06:25PM -0500, Gustavo A. R. Silva escreveu:
>> Hi all,
>>
>> Friendly ping (second one after 4 months):
>>
>> Who can take this?
> 
> Sorry for the delay, finally applied, thanks!
> 

Awesome. :)

Thanks, Arnaldo.
--
Gustavo

> - Arnaldo
>  
>> Thanks
>> --
>> Gustavo
>>
>> On 4/22/19 10:14 AM, Gustavo A. R. Silva wrote:
>>> Hi all,
>>>
>>> Friendly ping:
>>>
>>> Who can take this?
>>>
>>> Thanks
>>>
>>> On 4/8/19 11:27 AM, Gustavo A. R. Silva wrote:
>>>> In case memory resources for *buf* and *paths* were allocated,
>>>> jump to *out* and release them before return.
>>>>
>>>> Addresses-Coverity-ID: 1444328 ("Resource leak")
>>>> Fixes: 6f3da20e151f ("perf report: Support builtin perf script in scripts menu")
>>>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>>>> ---
>>>>  tools/perf/ui/browsers/scripts.c | 6 ++++--
>>>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/tools/perf/ui/browsers/scripts.c b/tools/perf/ui/browsers/scripts.c
>>>> index 27cf3ab88d13..f4edb18f67ec 100644
>>>> --- a/tools/perf/ui/browsers/scripts.c
>>>> +++ b/tools/perf/ui/browsers/scripts.c
>>>> @@ -131,8 +131,10 @@ static int list_scripts(char *script_name, bool *custom,
>>>>  		int key = ui_browser__input_window("perf script command",
>>>>  				"Enter perf script command line (without perf script prefix)",
>>>>  				script_args, "", 0);
>>>> -		if (key != K_ENTER)
>>>> -			return -1;
>>>> +		if (key != K_ENTER) {
>>>> +			ret = -1;
>>>> +			goto out;
>>>> +		}
>>>>  		sprintf(script_name, "%s script %s", perf, script_args);
>>>>  	} else if (choice < num + max_std) {
>>>>  		strcpy(script_name, paths[choice]);
>>>>
>