linux-kernel - Re: [PATCH] media: dvb: redundant assignment to variable tmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Aug 2019 16:10:33 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: dvb: redundant assignment to variable tmp

On Tue, Aug 27, 2019 at 12:15:27PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable tmp is being assigned a value that is never read and tmp
> is being re-assigned a little later on. The assignment is redundant
> and hence can be removed.
> 
> Addresses-Coverity: ("Ununsed value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/media/dvb-frontends/sp8870.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/dvb-frontends/sp8870.c b/drivers/media/dvb-frontends/sp8870.c
> index 655db8272268..f6793c9c2dc3 100644
> --- a/drivers/media/dvb-frontends/sp8870.c
> +++ b/drivers/media/dvb-frontends/sp8870.c
> @@ -378,8 +378,6 @@ static int sp8870_read_ber (struct dvb_frontend* fe, u32 * ber)
>  	if (ret < 0)
>  		return -EIO;
>  
> -	tmp = ret & 0x3F;
> -

This is pre git code.  It's not clear if the tmp is supposed to be used
or if we can remove the sp8870_readreg() call also...  The problem is
that we're disabling the warning without necessarily writing the best
fix.  It's better to leave the warning there until we are more sure of
the correct fix.  The warning has useful information and it's not
hurting anyone.

regards,
dan carpenter