linux-kernel - Re: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb49a1d9-8405-4f88-6f9a-af863bd0f657@amd.com>
Date:   Tue, 27 Aug 2019 14:01:24 +0000
From:   Harry Wentland <hwentlan@....com>
To:     YueHaibing <yuehaibing@...wei.com>,
        "Wentland, Harry" <Harry.Wentland@....com>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Zhou, David(ChunMing)" <David1.Zhou@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "Lakha, Bhawanpreet" <Bhawanpreet.Lakha@....com>,
        "Koo, Anthony" <Anthony.Koo@....com>,
        "Othman, Ahmad" <Ahmad.Othman@....com>,
        "Bernstein, Eric" <Eric.Bernstein@....com>,
        "Cyr, Aric" <Aric.Cyr@....com>,
        "alvin.lee3@....com" <alvin.lee3@....com>,
        "Tatla, Harmanprit" <Harmanprit.Tatla@....com>
CC:     "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] drm/amd/display: remove unused function
 setFieldWithMask

On 2019-08-27 3:09 a.m., YueHaibing wrote:
> After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"),
> there is no caller in tree.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Harry Wentland <harry.wentland@....com>

Harry

> ---
>  .../drm/amd/display/modules/info_packet/info_packet.c | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> index 5f4b98d..d885d64 100644
> --- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> +++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> @@ -114,25 +114,6 @@ enum ColorimetryYCCDP {
>  	ColorimetryYCC_DP_ITU2020YCbCr  = 7,
>  };
>  
> -void setFieldWithMask(unsigned char *dest, unsigned int mask, unsigned int value)
> -{
> -	unsigned int shift = 0;
> -
> -	if (!mask || !dest)
> -		return;
> -
> -	while (!((mask >> shift) & 1))
> -		shift++;
> -
> -	//reset
> -	*dest = *dest & ~mask;
> -	//set
> -	//dont let value span past mask
> -	value = value & (mask >> shift);
> -	//insert value
> -	*dest = *dest | (value << shift);
> -}
> -
>  void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
>  		struct dc_info_packet *info_packet)
>  {
>