linux-kernel - Re: [PATCH] uuid: Add helpers for finding UUID from an array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190827141122.GF2680@smile.fi.intel.com>
Date:   Tue, 27 Aug 2019 17:11:22 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] uuid: Add helpers for finding UUID from an array

On Tue, Aug 27, 2019 at 02:49:18PM +0300, Heikki Krogerus wrote:
> Matching function that compares every UUID in an array to a
> given UUID with guid_equal().

> I don't have a user for these helpers, but since they are pretty
> trivial, I figured that might as well propose them in any case.
> Though, I think there was somebody proposing of doing the same thing
> that these helpers do at one point, but just the hard way in the
> drivers, right Andy?


Candidates to use a helper
~~~~~~~~~~~~~~~~~~~~~~~~~~

acpi_is_property_guid(): seems like a candidate
nfit_spa_type(): seems like a candidate

xfs_uuid_unmount(): it looks for dups and holes

lmLogFileSystem(): it looks for holes


Below just users where UUID is a member of structure
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

visorbus_match() has two deviations: it uses embedded member and according to
code it allows having duplicate UUIDs, though it seems a side effect of not
strictly written code.

publish_vbus_dev_info()
tee_client_device_match()
hv_vmbus_dev_match()
hv_get_dev_type()
mei_cl_device_find()
ishtp_fw_cl_by_uuid()
is_unsupported_vmbus_devs()

...and few more.

-- 
With Best Regards,
Andy Shevchenko