linux-kernel - RE: [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due to u64/pointer abuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dbc03b4ac1ef4ba2a807409676cf8066@AcuMS.aculab.com>
Date:   Tue, 27 Aug 2019 14:17:40 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Geert Uytterhoeven' <geert@...ux-m68k.org>,
        Joe Perches <joe@...ches.com>
CC:     Bernard Metzler <bmt@...ich.ibm.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due to
 u64/pointer abuse

From: Geert Uytterhoeven
> Sent: 19 August 2019 18:15
...
> > I think a cast to unsigned long is rather more common.
> >
> > uintptr_t is used ~1300 times in the kernel.
> > I believe a cast to unsigned long is much more common.
> 
> That is true, as uintptr_t was introduced in C99.
> Similarly, unsigned long was used before size_t became common.
> 
> However, nowadays size_t and uintptr_t are preferred.

Isn't uintptr_t defined by the same standard as uint32_t?
If the former is allowed so should the latter.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)