linux-kernel - Re: [PATCH 1/2] powerpc/pseries: Delete an unnecessary kfree() call in dlpar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878sresn04.fsf@linux.ibm.com>
Date:   Tue, 27 Aug 2019 09:26:19 -0500
From:   Nathan Lynch <nathanl@...ux.ibm.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        Allison Randal <allison@...utok.net>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Frank Rowand <frank.rowand@...y.com>,
        Gen Zhang <blackgod016574@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        "Oliver O'Halloran" <oohall@...il.com>,
        Paul Mackerras <paulus@...ba.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1/2] powerpc/pseries: Delete an unnecessary kfree() call in dlpar_store()

Markus Elfring <Markus.Elfring@....de> writes:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 27 Aug 2019 13:34:02 +0200
>
> A null pointer would be passed to a call of the function “kfree”
> immediately after a call of the function “kstrdup” failed at one place.
> Remove this superfluous function call.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Acked-by: Nathan Lynch <nathanl@...ux.ibm.com>