linux-kernel - Re: [PATCH 1/9] staging: greybus: fix up SPDX comment in .h files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190827154343.GE534@kroah.com>
Date:   Tue, 27 Aug 2019 17:43:43 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Gao Xiang <gaoxiang25@...wei.com>
Cc:     devel@...verdev.osuosl.org, elder@...nel.org,
        Viresh Kumar <viresh.kumar@...aro.org>, yuchao0@...wei.com,
        johan@...nel.org, linux-kernel@...r.kernel.org,
        greybus-dev@...ts.linaro.org, Viresh Kumar <vireshk@...nel.org>
Subject: Re: [PATCH 1/9] staging: greybus: fix up SPDX comment in .h files

On Tue, Aug 27, 2019 at 05:20:36PM +0800, Gao Xiang wrote:
> Hi Greg,
> 
> On Tue, Aug 27, 2019 at 09:58:02AM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Aug 26, 2019 at 11:21:19AM +0530, Viresh Kumar wrote:
> > > On 25-08-19, 07:54, Greg Kroah-Hartman wrote:
> > > > When these files originally got an SPDX tag, I used // instead of /* */
> > > > for the .h files.  Fix this up to use // properly.
> > > > 
> > > > Cc: Viresh Kumar <vireshk@...nel.org>
> > > > Cc: Johan Hovold <johan@...nel.org>
> > > > Cc: Alex Elder <elder@...nel.org>
> > > > Cc: greybus-dev@...ts.linaro.org
> > > > Cc: devel@...verdev.osuosl.org
> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > > ---
> > > >  drivers/staging/greybus/firmware.h               | 2 +-
> > > >  drivers/staging/greybus/gb-camera.h              | 2 +-
> > > >  drivers/staging/greybus/gbphy.h                  | 2 +-
> > > >  drivers/staging/greybus/greybus.h                | 2 +-
> > > >  drivers/staging/greybus/greybus_authentication.h | 2 +-
> > > >  drivers/staging/greybus/greybus_firmware.h       | 2 +-
> > > >  drivers/staging/greybus/greybus_manifest.h       | 2 +-
> > > >  drivers/staging/greybus/greybus_protocols.h      | 2 +-
> > > >  drivers/staging/greybus/greybus_trace.h          | 2 +-
> > > >  drivers/staging/greybus/hd.h                     | 2 +-
> > > >  drivers/staging/greybus/interface.h              | 2 +-
> > > >  drivers/staging/greybus/manifest.h               | 2 +-
> > > >  drivers/staging/greybus/module.h                 | 2 +-
> > > >  drivers/staging/greybus/operation.h              | 2 +-
> > > >  drivers/staging/greybus/spilib.h                 | 2 +-
> > > >  drivers/staging/greybus/svc.h                    | 2 +-
> > > >  16 files changed, 16 insertions(+), 16 deletions(-)
> > > 
> > > Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> > 
> > Thanks for all of the acks!
> > 
> > greg k-h
> 
> I found similar issues of graybus when I tested the latest staging-testing
> 
> In file included from <command-line>:0:0:
> ./include/linux/greybus/greybus_protocols.h:45:2: error: unknown type name ‘__le16’
>   __le16 size;  /* Size in bytes of header + payload */
>   ^~~~~~
> ./include/linux/greybus/greybus_protocols.h:46:2: error: unknown type name ‘__le16’
>   __le16 operation_id; /* Operation unique id */
>   ^~~~~~
> ./include/linux/greybus/greybus_protocols.h:47:2: error: unknown type name ‘__u8’
>   __u8 type;  /* E.g GB_I2C_TYPE_* or GB_GPIO_TYPE_* */
>   ^~~~
> ./include/linux/greybus/greybus_protocols.h:48:2: error: unknown type name ‘__u8’
>   __u8 result;  /* Result of request (in responses only) */
>   ^~~~
> ./include/linux/greybus/greybus_protocols.h:49:2: error: unknown type name ‘__u8’
>   __u8 pad[2];  /* must be zero (ignore when read) */
>   ^~~~
> ./include/linux/greybus/greybus_protocols.h:58:2: error: unknown type name ‘__u8’
>   __u8 phase;
>   ^~~~
> ./include/linux/greybus/greybus_protocols.h:88:2: error: unknown type name ‘__u8’
>   __u8 major;
>   ^~~~
> ./include/linux/greybus/greybus_protocols.h:89:2: error: unknown type name ‘__u8’
>   __u8 minor;
>   ^~~~
> ./include/linux/greybus/greybus_protocols.h:93:2: error: unknown type name ‘__u8’
>   __u8 major;
>   ^~~~
> ./include/linux/greybus/greybus_protocols.h:94:2: error: unknown type name ‘__u8’
>   __u8 minor;
>   ^~~~
> ./include/linux/greybus/greybus_protocols.h:98:2: error: unknown type name ‘__u8’
>   __u8 bundle_id;
>   ^~~~
> ./include/linux/greybus/greybus_protocols.h:102:2: error: unknown type name ‘__u8’
>   __u8 major;
>   ^~~~
> ./include/linux/greybus/greybus_protocols.h:103:2: error: unknown type name ‘__u8’
>   __u8 minor;
>   ^~~~
> ./include/linux/greybus/greybus_protocols.h:108:2: error: unknown type name ‘__le16’
>   __le16   size;
>   ^~~~~~
> ./include/linux/greybus/greybus_protocols.h:113:2: error: unknown type name ‘__u8’
>   __u8   data[0];
>   ^~~~
> ./include/linux/greybus/greybus_protocols.h:118:2: error: unknown type name ‘__le16’
>   __le16   cport_id;
>   ^~~~~~
> ./include/linux/greybus/greybus_protocols.h:122:2: error: unknown type name ‘__le16’
>   __le16   cport_id;
> 
> .. and other files...
> 
> Not very sure... but it seems it can be observed with allmodconfig or
> CONFIG_KERNEL_HEADER_TEST=y and fail my compilation...
> Hope that of some help (kind reminder...)

Ah, thank you so much for this, NOW that makes sense why I got that odd
kbuild warning that I could not figure out.

Let me go fix this up, thank you so much.

greg k-h