linux-kernel - Re: [PATCH] rtc: pcf2127: bugfix: watchdog build dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190827162611.GB21922@piout.net>
Date:   Tue, 27 Aug 2019 18:26:11 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Bruno Thomsen <bruno.thomsen@...il.com>
Cc:     linux@...ck-us.net, yuehaibing@...wei.com, a.zummo@...ertech.it,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] rtc: pcf2127: bugfix: watchdog build dependency

On 27/08/2019 16:36:56+0200, Bruno Thomsen wrote:
> Disable watchdog registation when kernel is build without
> watchdog functionality, and enable watchdog core otherwise.
> This removes compile errors like the one below:
> 
> drivers/rtc/rtc-pcf2127.o: in function `pcf2127_probe.constprop.3':
> rtc-pcf2127.c:(.text.unlikely+0x2c8): undefined reference to
> `devm_watchdog_register_device'
> 
> Watchdog feature in chip will always be configured as
> this is safe to do in both cases and minimize code churn.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Reported-by: YueHaibing <yuehaibing@...wei.com>
> Fixes: bbc597561ce1 ("rtc: pcf2127: add watchdog feature support")
> Signed-off-by: Bruno Thomsen <bruno.thomsen@...il.com>
> ---
>  drivers/rtc/Kconfig       | 1 +
>  drivers/rtc/rtc-pcf2127.c | 2 ++
>  2 files changed, 3 insertions(+)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com