linux-kernel - Re: [PATCH] leds: syscon: Use resource managed variant of device register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d59f587-140b-9517-8b37-070817aea2ba@gmail.com>
Date:   Tue, 27 Aug 2019 23:32:12 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Alexander Dahl <ada@...rsis.com>, linux-leds@...r.kernel.org
Cc:     Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: syscon: Use resource managed variant of device
 register

Hi Alexander,

Thank you for the patch.

On 8/27/19 3:00 PM, Alexander Dahl wrote:
> We have a MFD driver compiled as module instantiating this driver. When
> unloading that module, those LED devices are not removed, which produces
> conflicts, when that module is inserted again.
> 
> Signed-off-by: Alexander Dahl <ada@...rsis.com>
> ---
>  drivers/leds/leds-syscon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-syscon.c b/drivers/leds/leds-syscon.c
> index e35dff0050f0..b58f3cafe16f 100644
> --- a/drivers/leds/leds-syscon.c
> +++ b/drivers/leds/leds-syscon.c
> @@ -115,7 +115,7 @@ static int syscon_led_probe(struct platform_device *pdev)
>  	}
>  	sled->cdev.brightness_set = syscon_led_set;
>  
> -	ret = led_classdev_register(dev, &sled->cdev);
> +	ret = devm_led_classdev_register(dev, &sled->cdev);
>  	if (ret < 0)
>  		return ret;

Applied.

-- 
Best regards,
Jacek Anaszewski