[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d3cb1cf5-f17f-38ef-66a2-23c1b7a7d08f@puri.sm>
Date: Tue, 27 Aug 2019 08:54:57 +0200
From: Martin Kepplinger <martin.kepplinger@...i.sm>
To: lorenzo.bianconi83@...il.com, jic23@...nel.org, knaack.h@....de,
lars@...afoo.de, pmeerw@...erw.net
Cc: robh+dt@...nel.org, mark.rutland@....com,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Lorenzo Bianconi <lorenzo@...nel.org>
Subject: Re: [PATCH v5 2/4] iio: imu: st_lsm6sdx: move register definitions to
sensor_settings struct
On 21.08.19 15:25, Martin Kepplinger wrote:
> Move some register definitions to the per-device array of struct
> st_lsm6dsx_sensor_settings in order to simplify adding new sensor
> devices to the driver.
>
> Also, remove completely unused register definitions.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@...i.sm>
> Acked-by: Lorenzo Bianconi <lorenzo@...nel.org>
> ---
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 6 ++++
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 31 ++++++++++++++------
> 2 files changed, 28 insertions(+), 9 deletions(-)
>
I just notices the commit message header typo "st_lsm6sdx" should be
"st_lsm6dsx" of course. If you can still rebase/force-push to testing,
would you be able to fix that? If it's too far out there already, so be
it :) sorry for the typo, and thanks for adding "-imu" yourself where
applicable.
thanks,
martin
Powered by blists - more mailing lists