[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190827072242.GT7538@dhcp22.suse.cz>
Date: Tue, 27 Aug 2019 09:22:42 +0200
From: Michal Hocko <mhocko@...nel.org>
To: Alastair D'Silva <alastair@...ilva.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Oscar Salvador <osalvador@...e.de>,
Mike Rapoport <rppt@...ux.ibm.com>,
Dan Williams <dan.j.williams@...el.com>,
Wei Yang <richardw.yang@...ux.intel.com>,
David Hildenbrand <david@...hat.com>, Qian Cai <cai@....pw>,
linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mm: don't hide potentially null memmap pointer in
sparse_remove_section
On Tue 27-08-19 17:00:16, Alastair D'Silva wrote:
[...]
> The NULL check was added in commit:
> 95a4774d055c ("memory-hotplug: update mce_bad_pages when removing the
> memory")
> where memmap was originally inited to NULL, and only conditionally
> given a value.
>
> With this in mind, since that situation is no longer true, I think we
> could instead drop the NULL check.
This would be much more preferable to the original patch.
--
Michal Hocko
SUSE Labs
Powered by blists - more mailing lists