linux-kernel - Re: sched,time: Allow better constprop/DCE for schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Aug 2019 09:26:36 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     kbuild-all@...org, Satendra Singh Thakur <sst2005@...il.com>,
        satendrasingh.thakur@....com, Ingo Molnar <mingo@...hat.com>,
        Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: sched,time: Allow better constprop/DCE for schedule_timeout()

Hi Peter,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc6 next-20190826]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Peter-Zijlstra/sched-time-Allow-better-constprop-DCE-for-schedule_timeout/20190827-061612
config: x86_64-lkp (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/uaccess.h:5:0,
                    from include/linux/crypto.h:21,
                    from arch/x86/kernel/asm-offsets.c:9:
   include/linux/sched.h: In function 'schedule_timeout':
>> include/linux/sched.h:222:3: error: implicit declaration of function 'schedule' [-Werror=implicit-function-declaration]
      schedule();
      ^~~~~~~~
   include/linux/sched.h: At top level:
   include/linux/sched.h:233:17: warning: conflicting types for 'schedule'
    asmlinkage void schedule(void);
                    ^~~~~~~~
   include/linux/sched.h:222:3: note: previous implicit declaration of 'schedule' was here
      schedule();
      ^~~~~~~~
   cc1: some warnings being treated as errors
   make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [sub-make] Error 2
   18 real  10 user  3 sys  78.71% cpu 	make prepare

vim +/schedule +222 include/linux/sched.h

   218	
   219	static inline long schedule_timeout(long timeout)
   220	{
   221		if (__builtin_constant_p(timeout) && timeout == MAX_SCHEDULE_TIMEOUT) {
 > 222			schedule();
   223			return timeout;
   224		}
   225	
   226		return __schedule_timeout(timeout);
   227	}
   228	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (27702 bytes)