linux-kernel - RE: [PATCH 07/14] serial: tegra: add compatible for new chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN6PR12MB27347E57CCA735DB36A49E73C3A00@SN6PR12MB2734.namprd12.prod.outlook.com>
Date:   Tue, 27 Aug 2019 09:29:48 +0000
From:   Krishna Yarlagadda <kyarlagadda@...dia.com>
To:     Thierry Reding <thierry.reding@...il.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "Laxman Dewangan" <ldewangan@...dia.com>,
        "jslaby@...e.com" <jslaby@...e.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 07/14] serial: tegra: add compatible for new chips

> -----Original Message-----
> From: Thierry Reding <thierry.reding@...il.com>
> Sent: Tuesday, August 13, 2019 3:26 PM
> To: Krishna Yarlagadda <kyarlagadda@...dia.com>
> Cc: gregkh@...uxfoundation.org; robh+dt@...nel.org;
> mark.rutland@....com; Jonathan Hunter <jonathanh@...dia.com>; Laxman
> Dewangan <ldewangan@...dia.com>; jslaby@...e.com; linux-
> serial@...r.kernel.org; devicetree@...r.kernel.org; linux-
> tegra@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 07/14] serial: tegra: add compatible for new chips
> 
> On Mon, Aug 12, 2019 at 04:58:16PM +0530, Krishna Yarlagadda wrote:
> > Add new compatible string for Tegra186. It differs from earlier chips
> > as it has fifo mode enable check and 8 byte dma buffer.
> > Add new compatible string for Tegra194. Tegra194 has different error
> > tolerance levels for baud rate compared to older chips.
> >
> > Signed-off-by: Krishna Yarlagadda <kyarlagadda@...dia.com>
> > ---
> >  Documentation/devicetree/bindings/serial/nvidia,tegra20-hsuart.txt |
> > 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> I think device tree binding patches are supposed to start with
> "dt-binding: ...".
> 
> Also: "fifo" -> "FIFO" and "dma" -> "DMA" in the commit message.
> 
> >
> > diff --git
> > a/Documentation/devicetree/bindings/serial/nvidia,tegra20-hsuart.txt
> > b/Documentation/devicetree/bindings/serial/nvidia,tegra20-hsuart.txt
> > index d7edf73..187ec78 100644
> > ---
> > a/Documentation/devicetree/bindings/serial/nvidia,tegra20-hsuart.txt
> > +++ b/Documentation/devicetree/bindings/serial/nvidia,tegra20-hsuart.t
> > +++ xt
> > @@ -1,7 +1,8 @@
> >  NVIDIA Tegra20/Tegra30 high speed (DMA based) UART controller driver.
> >
> >  Required properties:
> > -- compatible : should be "nvidia,tegra30-hsuart", "nvidia,tegra20-hsuart".
> > +- compatible : should be "nvidia,tegra30-hsuart",
> > +"nvidia,tegra20-hsuart",
> > +  nvidia,tegra186-hsuart, nvidia,tegra194-hsuart.
> 
> Please use quotes around the compatible strings like the existing ones.
> Also, I think it might be better to list these explicitly rather than just give a list
> of potential values. As it is right now, it's impossible to tell whether this is
> meant to say "should be all of these"
> or whether it is meant to say "should be one of these".
> 
> Thierry
> 
Will update in next version.
KY
> >  - reg: Should contain UART controller registers location and length.
> >  - interrupts: Should contain UART controller interrupts.
> >  - clocks: Must contain one entry, for the module clock.
> > --
> > 2.7.4
> >