linux-kernel - Re: [PATCH] r8188eu: use skb_put_data instead of skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190827103134.GC23584@kadam>
Date:   Tue, 27 Aug 2019 13:31:34 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Ivan Safonov <insafonov@...il.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sanjana Sanikommu <sanjana99reddy99@...il.com>,
        Vatsala Narang <vatsalanarang@...il.com>,
        Colin Ian King <colin.king@...onical.com>
Subject: Re: [PATCH] r8188eu: use skb_put_data instead of skb_put/memcpy pair

On Sun, Aug 25, 2019 at 11:48:58PM +0300, Ivan Safonov wrote:
> skb_put_data is shorter and clear.
> 

Please don't start the commit message in the middle of a sentence.  It
often gets split from the start of the sentence.  See how it looks here.
https://marc.info/?l=linux-driver-devel&m=156676594611401&w=2


> Signed-off-by: Ivan Safonov <insafonov@...il.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_recv.c        | 6 +-----
>  drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 3 +--
>  2 files changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
> b/drivers/staging/rtl8188eu/core/rtw_recv.c
> index 620da6c003d8..d4278361e002 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
> @@ -1373,11 +1373,7 @@ static struct recv_frame *recvframe_defrag(struct
> adapter *adapter,
>                 /* append  to first fragment frame's tail (if privacy frame,
> pull the ICV) */
>                 skb_trim(prframe->pkt, prframe->pkt->len -
> prframe->attrib.icv_len);


Your email client corrupted the patch so it can't be applied.

regards,
dan carpenter