linux-kernel - Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB7023773DD477FF89E2D2181CEEA00@VI1PR04MB7023.eurprd04.prod.outlook.com>
Date:   Tue, 27 Aug 2019 12:41:37 +0000
From:   Leonard Crestez <leonard.crestez@....com>
To:     Anson Huang <anson.huang@....com>, Shawn Guo <shawnguo@...nel.org>
CC:     Eduardo Valentin <edubezval@...il.com>,
        Zhang Rui <rui.zhang@...el.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        Stephen Boyd <sboyd@...nel.org>,
        Andrey Smirnov <andrew.smirnov@...il.com>
Subject: Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

On 27.08.2019 04:51, Anson Huang wrote:
>> In an earlier series the CLK_IS_CRITICAL flags was removed from the TMU
>> clock so if the thermal driver doesn't explicitly enable it the system will hang
>> on probe. This is what happens in linux-next right now!
> 
> The thermal driver should be built with module, so default kernel should can boot
> up, do you modify the thermal driver as built-in?
> 
>> Unless this patches is merged soon we'll end up with a 5.4-rc1 that doesn't
>> boot on imx8mq. An easy fix would be to drop/revert commit
>> 951c1aef9691 ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for
>> IMX8MQ_CLK_TMU_ROOT") until the thermal patches are accepted.
> 
> If the thermal driver is built as module, I think no need to revert the commit, but
> if by default thermal driver is built-in or mod probed, then yes, it should NOT break
> kernel boot up.

The qoriq_thermal driver is built as a module in defconfig and when 
modules are properly installed in rootfs they will be automatically be 
probed on boot and cause a hang.

I usually run nfsroot with modules:

     make modules_install INSTALL_MOD_PATH=/srv/nfs/imx8-root

--
Regards,
Leonard