linux-kernel - Re: [linux-next][BUG][driver/scsi/lpfc][c00f62e6] Kernel panics when booting next kernel on my Power 9 box

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1567014175.5082.6.camel@abdul>
Date:   Wed, 28 Aug 2019 23:12:55 +0530
From:   Abdul Haleem <abdhalee@...ux.vnet.ibm.com>
To:     James Smart <jsmart2021@...il.com>
Cc:     linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        linux-next <linux-next@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        sachinp <sachinp@...ux.vnet.ibm.com>,
        manvanth <manvanth@...ux.vnet.ibm.com>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        dick.kennedy@...adcom.com,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        dougmill <dougmill@...ux.vnet.ibm.com>,
        Brian King <brking@...ux.vnet.ibm.com>
Subject: Re: [linux-next][BUG][driver/scsi/lpfc][c00f62e6] Kernel panics
 when booting next kernel on my Power 9 box

On Wed, 2019-08-28 at 08:22 -0700, James Smart wrote:
> On 8/27/2019 10:02 PM, Abdul Haleem wrote:
> > Greetings,
> > 
> > linux-next kernel 5.3.0-rc1 failed to boot with kernel Oops on Power 9
> > box
> > 
> > I see a recent changes to lpfc code was from commit
> > 10541f03 scsi: lpfc: Update lpfc version to 12.4.0.0
> > 
> > Recent boot logs:
> > 
> > [..snip..]
> 
> see  https://www.spinics.net/lists/linux-scsi/msg133343.html
> 
> It hasn't been tested yet, but appears to be the issue.

Ah, commit c00f62e6 (scsi: lpfc: Merge per-protocol...) is the bad one
and Yes the patch fixes it, System booted fine with below code change

--- a/drivers/scsi/lpfc/lpfc_sli.c    2019-08-23 13:55:18.253546775 -0700
+++ b/drivers/scsi/lpfc_sli.c    2019-08-27 17:04:51.095330056 -0700
@@ -5553,7 +5553,7 @@ lpfc_sli4_arm_cqeq_intr(struct lpfc_hba
         for (qidx = 0; qidx < phba->cfg_hdw_queue; qidx++) {
             qp = &sli4_hba->hdwq[qidx];
             /* ARM the corresponding CQ */
-            sli4_hba->sli4_write_cq_db(phba, qp[qidx].io_cq, 0,
+            sli4_hba->sli4_write_cq_db(phba, qp->io_cq, 0,
                         LPFC_QUEUE_REARM);


Tested-by: Abdul Haleem <abdhalee@...ux.vnet.ibm.com>

-- 
Regard's

Abdul Haleem
IBM Linux Technology Centre