linux-kernel - Re: [PATCH v2] ipv6: Not to probe neighbourless routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20190828.125504.853814215014307743.davem@davemloft.net>
Date:   Wed, 28 Aug 2019 12:55:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     wang.yi59@....com.cn
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        xue.zhihong@....com.cn, wang.liang82@....com.cn,
        cheng.lin130@....com.cn
Subject: Re: [PATCH v2] ipv6: Not to probe neighbourless routes

From: <wang.yi59@....com.cn>
Date: Wed, 28 Aug 2019 16:50:08 +0800 (CST)

> We used an older version of the kernel, and found that configuring default
> route led to a lot of NS messages, which affected the real business.
> 
> Although commit f547fac624be adds rate-limiting, there are still some
> unreasonable things.
> 
> We have tested this change on CentOS 7.6 (3.10.0-957), whose rt6_probe()
> implementation is similar to the latest code. When remaking patch based on
> linux-5.3-rc5, a line of code was missed out with a mistack.

Therefore, you are not testing this patch on current kernels, so you are
sending a patch which is completely untested.

This is not appropriate nor accceptable.