linux-kernel - Re: [FYI] lm3532: right registration to work with LED-backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3ac1863-9cdb-1ba6-d5a4-df1c4cfecbe1@gmail.com>
Date:   Wed, 28 Aug 2019 22:32:57 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Pavel Machek <pavel@....cz>, Tony Lindgren <tony@...mide.com>,
        kernel list <linux-kernel@...r.kernel.org>, sre@...nel.org,
        nekit1000@...il.com, mpartap@....net, merlijn@...zup.org
Cc:     Dan Murphy <dmurphy@...com>, linux-leds@...r.kernel.org
Subject: Re: [FYI] lm3532: right registration to work with LED-backlight

On 8/28/19 10:53 AM, Pavel Machek wrote:
> Hi!
> 
> Eventually, these will be needed.
> 
> Best regards,
> 								Pavel
> 
> commit 38d956977a7d6cbdc811676f9b4033da7487e045
> Author: Pavel <pavel@....cz>
> Date:   Wed Aug 7 12:43:52 2019 +0200
> 
>     d4: lm3532 needs to use right register function for backlight to work.
> 
> diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c
> index 365a22a5..f98e657 100644
> --- a/drivers/leds/leds-lm3532.c
> +++ b/drivers/leds/leds-lm3532.c
> @@ -629,7 +629,7 @@ static int lm3532_parse_node(struct lm3532_data *priv)
>  
>  		lm3532_init_registers(led);
>  
> -		ret = devm_led_classdev_register(priv->dev, &led->led_dev);
> +		ret = devm_of_led_classdev_register(priv->dev, to_of_node(child), &led->led_dev);

We no longer have devm_of_led_classdev_register(). You must use
devm_led_classdev_register_ext().

-- 
Best regards,
Jacek Anaszewski