linux-kernel - Re: [PATCH 0/3] PCI/ACPI: Rename _HPP to _HPX and move of ACPI-specific code from probe.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Aug 2019 15:33:52 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Krzysztof Wilczynski <kw@...ux.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, linux-pci@...r.kernel.org,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] PCI/ACPI: Rename _HPP to _HPX and move of
 ACPI-specific code from probe.c

On Tue, Aug 27, 2019 at 11:49:48AM +0200, Krzysztof Wilczynski wrote:
> This series of patches moves the ACPI-specific code currently included
> as part of the drivers/pci/probe.c. First, the ACPI Hot Plug structs
> for Type 0, 1 and 2, and any relevant variable names, structs, function
> names, etc., will have their names changed to reflect that these are
> related to _HPX rather than _HPP.  Second, all of the ACPI-specific
> code will be moved to drivers/pci/pci-acpi.c for better organisation
> and to keep ACPI-related code base together.  Third, remove the
> now obsolete struct hotplug_program_ops from drivers/pci/pci-acpi.c.
> 
> Patches should be preferably merged in order as they build upon
> one-another.

This is always the case; it's one of the main reasons for grouping
patches into a series.

> Related:
>   https://lore.kernel.org/lkml/20190419220220.GI173520@google.com
>   https://lore.kernel.org/lkml/20190307213834.5914-3-mr.nuke.me@gmail.com
>   https://lore.kernel.org/lkml/20190307213834.5914-2-mr.nuke.me@gmail.com
> 
> Krzysztof Wilczynski (3):
>   PCI/ACPI: Rename ACPI Hot Plug structs for Type 0, 1 and 2 from _HPP
>     to _HPX
>   PCI/ACPI: Move ACPI-specific Hot Plug programming functions to
>     pci-acpi.c
>   PCI/ACPI: Remove unnecessary struct hotplug_program_ops from
>     pci-acpi.c
> 
>  drivers/pci/pci-acpi.c      | 410 +++++++++++++++++++++++++++++++++---
>  drivers/pci/pci.h           |   9 +
>  drivers/pci/probe.c         | 278 +-----------------------
>  include/linux/pci_hotplug.h | 100 ---------
>  4 files changed, 389 insertions(+), 408 deletions(-)

I applied these to pci/enumeration for v5.4, thanks!