linux-kernel - [PATCH 2/3] tracing: remove exported but unused trace_array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Aug 2019 22:25:48 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     rostedt@...dmis.org
Cc:     mingo@...hat.com, linux-kernel@...r.kernel.org,
        oss-drivers@...ronome.com,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Subject: [PATCH 2/3] tracing: remove exported but unused trace_array_destroy()

trace_array_destroy() is an exported symbol, but not only
are there no in-tree callers, it doesn't actually have
a declaration in any header.

This fixes the "no previous prototype for" warning.

Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
---
 kernel/trace/trace.c | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 947ba433865f..4cd9855dcd88 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -8438,25 +8438,6 @@ static int __remove_instance(struct trace_array *tr)
 	return 0;
 }
 
-int trace_array_destroy(struct trace_array *tr)
-{
-	int ret;
-
-	if (!tr)
-		return -EINVAL;
-
-	mutex_lock(&event_mutex);
-	mutex_lock(&trace_types_lock);
-
-	ret = __remove_instance(tr);
-
-	mutex_unlock(&trace_types_lock);
-	mutex_unlock(&event_mutex);
-
-	return ret;
-}
-EXPORT_SYMBOL_GPL(trace_array_destroy);
-
 static int instance_rmdir(const char *name)
 {
 	struct trace_array *tr;
-- 
2.21.0