linux-kernel - Re: [PATCH 2/8] regulator: add support for SY8824C regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190828133757.6a0fe6dd@xhacker.debian>
Date:   Wed, 28 Aug 2019 05:49:16 +0000
From:   Jisheng Zhang <Jisheng.Zhang@...aptics.com>
To:     Mark Brown <broonie@...nel.org>
CC:     Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH 2/8] regulator: add support for SY8824C regulator

On Wed, 28 Aug 2019 11:27:05 +0800 Jisheng Zhang wrote:

> Hi Mark,
> 
> On Tue, 27 Aug 2019 20:44:37 +0100 Mark Brown wrote:
> 
> > On Tue, Aug 27, 2019 at 08:45:33AM +0000, Jisheng Zhang wrote:
> > 
> > This looks mostly good and I'll apply it, a couple of small
> > things though:
> >   
> > > @@ -0,0 +1,192 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * SY8824C regulator driver
> > > + *    
> > 
> > Please send a patch which updates the entire comment block to be
> > C++ style so it looks consistent.  
> 
> Do you mean update the following style
> 
> A:
> 
> // SPDX-License-Identifier: GPL-2.0
> /*
>  * SY8824C regulator driver
>  * ...
> 
> 
> as B:
> 
> // SPDX-License-Identifier: GPL-2.0
> // SY8824C regulator driver
> // ...
> 
> I'm not sure which style is correct. But I see B is commonly used

sorry, typo. I mean "I see A is commonly used ..."

> in lots .c source files in other dirs, such as kernel/ mm/ etc.
> 
> Could you please clarify?
> 
> Thanks
> 
> >   
> > > +#define BUCK_EN		(1 << 7)
> > > +#define MODE		(1 << 6)
> > > +    
> > 
> > Please also add prefixes to these to namespace them, especially
> > MODE is likely to collide with something later.  
> 
> good idea. Will do in newer version