linux-kernel - Re: [PATCH] mm/oom_kill.c: fox oom_cpuset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190828071021.GD7386@dhcp22.suse.cz>
Date:   Wed, 28 Aug 2019 09:10:21 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Yi Wang <wang.yi59@....com.cn>
Cc:     akpm@...ux-foundation.org, penguin-kernel@...ove.SAKURA.ne.jp,
        guro@...com, shakeelb@...gle.com, yuzhoujian@...ichuxing.com,
        jglisse@...hat.com, ebiederm@...ssion.com, hannes@...xchg.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        xue.zhihong@....com.cn, up2wing@...il.com, wang.liang82@....com.cn
Subject: Re: [PATCH] mm/oom_kill.c: fox oom_cpuset_eligible() comment

s@fox@fix@

On Wed 28-08-19 10:38:49, Yi Wang wrote:
> Commit ac311a14c682 ("oom: decouple mems_allowed from oom_unkillable_task")
> changed the function has_intersects_mems_allowed() to
> oom_cpuset_eligible(), but didn't change the comment meanwhile.
> 
> Let's fix this.
> 
> Signed-off-by: Yi Wang <wang.yi59@....com.cn>

Acked-by: Michal Hocko <mhocko@...e.com>

Thanks!

> ---
>  mm/oom_kill.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index eda2e2a..65c092e 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -73,7 +73,7 @@ static inline bool is_memcg_oom(struct oom_control *oc)
>  /**
>   * oom_cpuset_eligible() - check task eligiblity for kill
>   * @start: task struct of which task to consider
> - * @mask: nodemask passed to page allocator for mempolicy ooms
> + * @oc: pointer to struct oom_control
>   *
>   * Task eligibility is determined by whether or not a candidate task, @tsk,
>   * shares the same mempolicy nodes as current if it is bound by such a policy
> -- 
> 1.8.3.1
> 

-- 
Michal Hocko
SUSE Labs