linux-kernel - [PATCH] mm: fix -Wmissing-prototypes warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Aug 2019 15:42:41 +0800
From:   Yi Wang <wang.yi59@....com.cn>
To:     akpm@...ux-foundation.org
Cc:     keescook@...omium.org, dan.j.williams@...el.com,
        wang.yi59@....com.cn, cai@....pw, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, osalvador@...e.de, mhocko@...e.com,
        rppt@...ux.ibm.com, david@...hat.com,
        richardw.yang@...ux.intel.com, xue.zhihong@....com.cn,
        up2wing@...il.com, wang.liang82@....com.cn
Subject: [PATCH] mm: fix -Wmissing-prototypes warnings

We get two warnings when build kernel W=1:
mm/shuffle.c:36:12: warning: no previous prototype for ‘shuffle_show’
[-Wmissing-prototypes]
mm/sparse.c:220:6: warning: no previous prototype for
‘subsection_mask_set’ [-Wmissing-prototypes]

Make the function static to fix this.

Signed-off-by: Yi Wang <wang.yi59@....com.cn>
---
 mm/shuffle.c | 2 +-
 mm/sparse.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/shuffle.c b/mm/shuffle.c
index 3ce1248..b3fe97f 100644
--- a/mm/shuffle.c
+++ b/mm/shuffle.c
@@ -33,7 +33,7 @@ __meminit void page_alloc_shuffle(enum mm_shuffle_ctl ctl)
 }
 
 static bool shuffle_param;
-extern int shuffle_show(char *buffer, const struct kernel_param *kp)
+static int shuffle_show(char *buffer, const struct kernel_param *kp)
 {
 	return sprintf(buffer, "%c\n", test_bit(SHUFFLE_ENABLE, &shuffle_state)
 			? 'Y' : 'N');
diff --git a/mm/sparse.c b/mm/sparse.c
index 72f010d..49006dd 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -217,7 +217,7 @@ static inline unsigned long first_present_section_nr(void)
 	return next_present_section_nr(-1);
 }
 
-void subsection_mask_set(unsigned long *map, unsigned long pfn,
+static void subsection_mask_set(unsigned long *map, unsigned long pfn,
 		unsigned long nr_pages)
 {
 	int idx = subsection_map_index(pfn);
-- 
1.8.3.1